search

bmoscon / cryptofeed

Cryptocurrency Exchange Websocket Data Feed Handler
Other
2.19k stars 680 forks source link

possible bug: check with capital "U" guards access with lowercase #822

Closed shaunc closed 2 years ago

shaunc commented 2 years ago

This seems like a bug, though I haven't hit it: note msg['U'] vs msg['u'].

https://github.com/bmoscon/cryptofeed/blob/097bdabd071d4998448eb7f45a01b1d2b6b3e7c2/cryptofeed/exchanges/binance.py#L266-L267

bmoscon commented 2 years ago

the code follows the docs: https://binance-docs.github.io/apidocs/spot/en/#how-to-manage-a-local-order-book-correctly

Feel free to verify and raise an issue if you find a bug

shaunc commented 2 years ago

Right -- sorry about that!