Though this PR resolves the issue, I think it would be much better to do `connection-dependent'' resetting in all exchanges by implementing a shared_reset(self, conn: AsyncConnection)method in theFeed` base class and overload it when necessary in the derived classes. Since this change would affect all exchanges, I'd first like to know whether there is a shared interest for this refactoring.
In addition, while solving the original issue I came across two issues:
When passing multiple symbols in a subscription message for Phemex, only the first symbol seems to be accepted. This seems counter to their documentation, so please double check. The workaround is to send a subscription for each symbol individually.
There was a small but crucial bug in the subscription message for perpetuals on BitDotCom.
Description of code - what bug does this fix / what feature does this add?
This PR solves https://github.com/bmoscon/cryptofeed/issues/848. It solves the issue in all exchanges where I could replicate the bug.
Though this PR resolves the issue, I think it would be much better to do
`connection-dependent'' resetting in all exchanges by implementing a shared
_reset(self, conn: AsyncConnection)method in the
Feed` base class and overload it when necessary in the derived classes. Since this change would affect all exchanges, I'd first like to know whether there is a shared interest for this refactoring.In addition, while solving the original issue I came across two issues:
When passing multiple symbols in a subscription message for Phemex, only the first symbol seems to be accepted. This seems counter to their documentation, so please double check. The workaround is to send a subscription for each symbol individually.
There was a small but crucial bug in the subscription message for perpetuals on BitDotCom.
[x] - Tested
[x] - Changelog updated
[x] - Tests run and pass
[x] - Flake8 run and all errors/warnings resolved
[ ] - Contributors file updated (optional)