bmpenuelas / systemverilog-formatter-vscode

Beautify SystemVerilog code in VSCode through Verible
MIT License
15 stars 4 forks source link

use registerDocumentRangeFormattingEditProvider instead of registerDocumentRangeFormattingEditProvider #3

Closed hirooih closed 3 years ago

hirooih commented 3 years ago

Thank you for your extension.

This pull request adds Format Selection feature in addition to Format Document feature.


Some notes;

If you agree, I am happy to provide you fixes for above.

Again thank you for your sharing this extension.

bmpenuelas commented 3 years ago

Thanks a lot for your contribution!

Regarding semicolons vs no-semicolons I don't have a strong opinion, however, I happened to read this tweet minutes before starting the repo and upon reading about the topic it looks like there are situations in ts where no-sc makes errors surface earlier.

As for exposing the commands, I preferred to expose them even if you can use the built-in's because there are cases where you might want to fire them directly. For example, if you have several formatters and use another one by default but you'd like to run this one manually some times.

Please let me know if you'd like to add more commits before merging the PR or it's good to go.

hirooih commented 3 years ago

I don't have any plan of additional commit now. Please merge my fix. Thanks.

bmpenuelas commented 3 years ago

Great, there it goes!