search

bmrb-io / BMRBdep

BMRB current generation deposition server.
2 stars 0 forks source link

Enumeration ties are not backwards-filling #149

Open jonwedell opened 4 years ago

jonwedell commented 4 years ago

The issue is caused by the code being written in a way to support enumeration ties and default enumerations.

jonwedell commented 4 years ago

There is a potential here to add functionality in the process of refactoring this - we could group the various selectable options depending on where they came from. For example, "Suggested Values" for standard enumerations, or "Entities" for a tag that also has an entity link, etc.

For an example: https://material.angular.io/components/select/overview#creating-groups-of-options

elulrich commented 4 years ago

Is it possible to trigger a 'leave' and 'return' in here somewhere as this operation does seem to make the links work going forward in the deposition.

This seems to be different. I am going forward from contact person to entry authors. Also, I have reproduced the effect where the link does not work when first entering contact person information and then going to chemical shift referencing and returning to entry information. When I do this I do see the contact person names as a selection list in entry author first name field, for example.

jonwedell commented 4 years ago

I will investigate further. In theory, navigating around the entry shouldn't change which values show up. Only changing a tag value (somewhere) should trigger an update.

Is it just navigating forward and backwards which fixes it, or did you also enter information in one of the other sections before returning?

elulrich commented 4 years ago

Just repeated.

  1. started new dep
  2. enter values in contact first and last name fields for both rows (no other fields populated)
  3. did not appear in entry author fields (single, double clicked in several places in the fields
  4. from menu went to chemical shift referencing
  5. click in chem shift ref window so it became unshaded
  6. from menu went back to entry information
  7. clicked in entry author first name field and the list appeared.

Eldon On 12/18/19 9:58 AM, Jon Wedell wrote:

I will investigate further. In theory, navigating around the entry shouldn't change which values show up. Only changing a tag value (somewhere) should trigger an update.

Is it just navigating forward and backwards which fixes it, or did you also enter information in one of the other sections before returning?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/uwbmrb/BMRBdep/issues/149?email_source=notifications&email_token=AFIKCPLJGSKVAMSK7ZJK6ITQZJCCHA5CNFSM4JVOLRD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHGSW3Y#issuecomment-567094127, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFIKCPNDT5QO27DPCO5ZIOTQZJCCHANCNFSM4JVOLRDQ.