search

bmrb-io / PyNMRSTAR

A Python module for reading, writing, and manipulating NMR-STAR files.
MIT License
28 stars 3 forks source link

tests run on pytest and unittest updates to docs #115

Closed varioustoxins closed 8 months ago

varioustoxins commented 1 year ago

John I have been playing a bit, please find attached the following if you find them useful. If not please feel fine to reject away!

  1. changes to make unit tests run with pytest as well as unites
  2. additions to the commendation detailing how to setup the unittests and run them
jonwedell commented 1 year ago

Hey,

I like the addition to the readme and am happy to incorporate it. I'd prefer not to copy the entire tests to a new file - that has lost all history of the development of the tests. (And I often look at the history to understand how and why things have come to be.)

I found that by making a symlink in the unit test directory called test_pynmrstar.py which points to __init__.py I was able to run pytest following the readme without modifying the existing test code. Are you okay using that approach instead?

I can either take your changes to the readme (and create the symlink) and make them locally and push, you can update the pull request to incorporate them, or if you'd prefer to move the actual contents of the unit tests as you've done you're welcome to keep progressing in that direction in your fork but I don't think I'll merge it. Let me know what you'd prefer, and thanks!

varioustoxins commented 8 months ago

hi John sorry missed your replies long ago, did you incorporate or would you still ike me to modify and push

jonwedell commented 8 months ago

No problem - I incorporated (with some minor updates to the docs) these changes into the upcoming release. Thanks!