search

bmrb-io / nmr-star-dictionary

The official NMR-STAR dictionary in use by the BMRB.
3 stars 3 forks source link

3.2.14.0 dictionary Save_frame_category missing data items #64

Open epeisach opened 3 years ago

epeisach commented 3 years ago

Dictionary linked from BMRB website https://raw.githubusercontent.com/uwbmrb/nmr-star-dictionary/nmr-star-production/NMR-STAR/internal_106_distribution/NMR-STAR.dic

Around line 127: Five data items

loop_
   _Save_frame_category.Name
   _Save_frame_category.Description
   _Save_frame_category.Super_save_frame_group_ID
   _Save_frame_category.Super_save_frame_group_name
   _Save_frame_category.Dictionary_ID

Yet there are only four: (I think Super_save_frame_group_name is missing)

'deposited_data_files' ; Categories that capture information about the data files that are uploaded for depositions. ;

 'R'     NMR-STAR

'entry_interview' ; Categories that record an overview of the information to be deposited by an author. ;

 'R'     NMR-STAR

.......

epeisach commented 3 years ago

Followup:

'NMR_spectrometer_expt_list'

section is missing the R item

dmaziuk commented 3 years ago

I've no idea what 'R' stands for either: it's not a supergroup ID nor name. (It looks like "mandatory code" except it's wrong: they wouldn't all be R(equired) either.)

IIRC "super categories" make up ADIT's top-level items in the left-side menu. Jon, I assume they're still used in NMRdep? (And we can't just get rid of them?)

jonwedell commented 3 years ago

Hey Ezra,

Thanks for filing this report. We're aware of the issue, and the code that @vrvonteddu is working on doesn't reproduce this bug. I'll close this ticket when we've got a new version released.

Dimitri - super categories are still in use, yes. I believe the R values are just a bug in Eldon's code. No idea where it would come from.

Jon