Remove excessive paths parameter on calling to polygon()

bmsleight / lasercut

Module for openscad, allowing 3d models to be created from 2d lasercut parts

BSD 2-Clause "Simplified" License

318 stars 54 forks source link

Remove excessive paths parameter on calling to polygon() #12

Closed dogtopus closed 5 years ago

dogtopus commented 5 years ago

It seems excessive to me since openscad follows the natural order of points by default when constructing a polygon and the path variable here represents nothing but natural order. It is also broken since paths should be a list of vectors, not a single list.

(https://en.wikibooks.org/wiki/OpenSCAD_User_Manual/The_OpenSCAD_Language#polygon)

moozer commented 5 years ago

I second this.

The change on line 88 in lasercut.scad in pull request #11 broke the system for me.

The lasercutoutSquare() simply creates nothing and there are no errors.

Removing the paths= makes it function correctly again.

I'm using OpenSCAD version 2019.02.07.

bmsleight commented 5 years ago

Added untested, but @moozer appears to verify.

dogtopus commented 5 years ago

@moozer It was broken and got masked by the typo. I fixed the typo in #11 and the problem began to surface.

moozer commented 5 years ago

I just pulled the latest, and it works for me now.