Open phdoerfler opened 5 years ago
I like the idea. I will add to a to do file.
Any PR as a starter ?
@phdoerfler if you're still interested in this, I've added a finger_width to my fork https://github.com/AlexCPU/openscad-lasercut/pull/4. I haven't submitted a PR to this, as I've made breaking changes to get symmetrical fingers.
@AlexCPU interesting, thanks for the pointer!
Wow, I was just about to open an issue when I saw @AlexCPU has already done it!
I like using this lasercut tool a lot in my OpenSCAD projects, I recently made them available here.
What I'm missing are two features:
symmetric
flag, false by default, or always use symmetric just like Alex does. I must note that unsymmetric parts are really a pain in the neck: I need to assemble the parts before adding any glue to make sure I haven't messed up with the sides. Symmetric joints will decrease the number of such mistakes. Also, my colleagues, who prefer designing in AutoCAD, always produce symmetric parts and I find them neat.simple_tabs
and simple_tab_holes
:
finger_width = 14;
lasercutoutSquare(thickness=thickness, x=x, y=y, simple_tabs=[ [UP, x/2, y, finger_width], [DOWN, x/2, finger_width] ] );
Alternatively, we can borrow Alex's approach to pass the `finger_width` as another parameter but such an approach forces all finger joints (inner and outer) to be of the same size.
Simple tab finger joints larger than the material thickness will sustain more weight put on them (see the inner stut in my [router case](https://github.com/dizcza/lasercut_collection/blob/master/router-case.scad) example).
---
In either case, I'd like to see Alex's PR merged! That's really a great job.
Hi @dizcza Thanks for links to your made boxes - great motivation to me that library is being used.
Concerned that @AlexCPU PR had breaking changes. If a PR can be open with additional parameters with good backward compatibility I will pull it.
I will have at inner stut.
Boxes like this (
num_fingers = 2
) would look nicer if the finger width would be more consistent between short and long sides:Either implement some
finger_width
parameter or turnnum_fingers
into an array so it's possible to specify the number of fingers per side.