bmsleight / lasercut

Module for openscad, allowing 3d models to be created from 2d lasercut parts
BSD 2-Clause "Simplified" License
317 stars 53 forks source link

lasercutoutBox: have num_fingers be an array (vs. a scalar value) #13

Open phdoerfler opened 5 years ago

phdoerfler commented 5 years ago

Boxes like this (num_fingers = 2) would look nicer if the finger width would be more consistent between short and long sides:

image

Either implement some finger_width parameter or turn num_fingers into an array so it's possible to specify the number of fingers per side.

bmsleight commented 4 years ago

I like the idea. I will add to a to do file.

Any PR as a starter ?

AlexCPU commented 1 year ago

@phdoerfler if you're still interested in this, I've added a finger_width to my fork https://github.com/AlexCPU/openscad-lasercut/pull/4. I haven't submitted a PR to this, as I've made breaking changes to get symmetrical fingers.

image
phdoerfler commented 1 year ago

@AlexCPU interesting, thanks for the pointer!

dizcza commented 1 year ago

Wow, I was just about to open an issue when I saw @AlexCPU has already done it!

I like using this lasercut tool a lot in my OpenSCAD projects, I recently made them available here.

What I'm missing are two features:

lasercutoutSquare(thickness=thickness, x=x, y=y, simple_tabs=[ [UP, x/2, y, finger_width], [DOWN, x/2, finger_width] ] );


Alternatively, we can borrow Alex's approach to pass the `finger_width` as another parameter but such an approach forces all finger joints (inner and outer) to be of the same size.

Simple tab finger joints larger than the material thickness will sustain more weight put on them (see the inner stut in my [router case](https://github.com/dizcza/lasercut_collection/blob/master/router-case.scad) example).

---

In either case, I'd like to see Alex's PR merged! That's really a great job.
bmsleight commented 1 year ago

Hi @dizcza Thanks for links to your made boxes - great motivation to me that library is being used.

Concerned that @AlexCPU PR had breaking changes. If a PR can be open with additional parameters with good backward compatibility I will pull it.

I will have at inner stut.