bmsleight / lasercut

Module for openscad, allowing 3d models to be created from 2d lasercut parts
BSD 2-Clause "Simplified" License
318 stars 54 forks source link

Created python version of convert-2d to enable Windows compatibility #27

Closed dcm684 closed 2 years ago

dcm684 commented 2 years ago

The bash script converter could not be used by Windows users. This new script allows users of Windows, OSX, and Linux to convert their lasercut OpenSCAD projects to 2D files.

In addition to added Windows compatibility these other improvements were added:

Tested on Windows with 64-bit installation. Code for OSX and Linux openscad path determination is untested but was taken straight from convert-2d.sh script.

Updated README.md to reflect addition of convert-2d.py

bmsleight commented 2 years ago

Wow - looks really good, thanks for the hard work. Will try and review this weekend.

dcm684 commented 2 years ago

Have you had a chance to review the script? Is there anything that I should change?

bmsleight commented 2 years ago

No sorry not had a chance. Apologies. Looks good. Heck - lets merge and see if I can test next week. [We not talking safety critical software :) ]

Thanks for the work. I must start a contributors file soon.