Bug in logging the key setting message

bmuller / kademlia

A DHT in Python using asyncio

http://kademlia.readthedocs.org

MIT License

830 stars 210 forks source link

Bug in logging the key setting message #26

Closed pendleto closed 7 years ago

pendleto commented 7 years ago

When republishing the keys the key object is a digest, not a string so it cannot be printed
Do not log the key or values because they may not be printable
Remove the digest from the set

pendleto commented 7 years ago

With this change the client is required to perform the hash of the key if desired. The problem with the previous code is that the hashed key would get rehashed if the keys were republished.

bmuller commented 7 years ago

I think this has now been fixed in e58c710 - feel free to reopen an issue or PR if not. Thanks, and great catch!