search

bmuller / kademlia

A DHT in Python using asyncio
http://kademlia.readthedocs.org
MIT License
830 stars 210 forks source link

Add shebang to examples #90

Closed frafra closed 3 years ago

frafra commented 3 years ago

Hey @bmuller, thank you for your reply. I made them executable, but I am not sure on renaming them; it is still valid to keep the extension, as some editors rely on file extensions, but if you are sure about that I can drop it.

bmuller commented 3 years ago

Hey @frafra, I've thought about this some more, and I think the best thing to do would be to leave these as .py files that are not executable (and thus no hashbang). The files exist to provide Python examples of how to write code that uses the lib, not to act as utilities (executable bins) that people should run to do things. They're just example Python files, and, as such, I think should remain as is.

I'm going to close the PR, but please feel free to comment if you have a different view. I'm open to being convinced otherwise. And thanks for the contribution!

frafra commented 3 years ago

No problem, it is a respectable opinion :-) It is your project after all :-)