bmuller / twistar

Twistar is an object-relational mapper (ORM) for Python that uses the Twisted library to provide asynchronous DB interaction.
http://findingscience.com/twistar
Other
132 stars 38 forks source link

Use inlineCallbacks in instead of DeferredList; fixes #35 #36

Closed erikkaplun closed 11 years ago

erikkaplun commented 11 years ago

I tried to understand it but could not figure out why this might have fixed the issue. I also tried adding fireOnFirstErrback=True and fireOnFirstErrback=True, consumeErrors=True to DeferredList, and also adding errbacks to everything, to no avail—nothing was printed and the issue persisted.

Unless you have a reason to believe using inlineCallbacks here is somehow bad or hides a/the real issue, this commit seems to have fixed it. The change also makes the test more readable (as inlineCallbacks always does).