Improve unit testing by means of Tox and Coveralls

bmuller / twistar

Twistar is an object-relational mapper (ORM) for Python that uses the Twisted library to provide asynchronous DB interaction.

http://findingscience.com/twistar

Other

132 stars 38 forks source link

Improve unit testing by means of Tox and Coveralls #59

Closed evilaliv3 closed 8 years ago

evilaliv3 commented 8 years ago

With this commit:

test are now implemented using Tox
tests are now performed on all the relevant versions of twisted (12, 13, 14, 15)
tests are now performed on all the relevant versions of python (2.7, 3.5, pypy, pypy3)
code coverage is collected during tests and published on README.md and at https://coveralls.io/github/evilaliv3/twistar

evilaliv3 commented 8 years ago

screenshot from 2016-01-04 04 28 34

evilaliv3 commented 8 years ago

ok @bmuller, i've updated the readme badges making them point to your repository.

no you have simply to login on coveralls and activate coveralls on your repository.

bmuller commented 8 years ago

When I run tox I get an error:

GLOB sdist-make: /private/tmp/twistar/setup.py
coverage recreate: /private/tmp/twistar/.tox/coverage
coverage inst: /private/tmp/twistar/.tox/dist/twistar-1.3.zip
coverage installed: twistar==1.3,Twisted==15.5.0,wheel==0.24.0,zope.interface==4.1.3
coverage runtests: PYTHONHASHSEED='2194578734'
coverage runtests: commands[0] | coverage erase
ERROR: InvocationError: could not find executable 'coverage'
...

Also, I think .coverage and .tox should be added to the .gitignore file, right?

evilaliv3 commented 8 years ago

let me check and i will be back to you

evilaliv3 commented 8 years ago

here you go man!

bmuller commented 8 years ago

Thanks @evilaliv3!

evilaliv3 commented 8 years ago

you are welcome @bmuller !

strangely the coveralls badge is not updating.

try to put this badge url that has a specifc query arg mentioning github and lets see if with the first real commit by you it will start working:

[![Coverage Status](https://coveralls.io/repos/bmuller/twistar/badge.svg?branch=master&service=github)](https://coveralls.io/github/bmuller/twistar?branch=master)

bmuller commented 8 years ago

Yeah, I saw that - looks like there's no coverage info for the last commit - https://coveralls.io/builds/4632048

evilaliv3 commented 8 years ago

i do not know what to say, have you logged into coveralls; it says something about it?

maybe my branch is magic and your is not!

bmuller commented 8 years ago

@evilaliv3 It took a bit to track down! It was this line in the tox.ini, where [testenv:coveralls] should have been [testenv:coverage].