search

bmuller / twistar

Twistar is an object-relational mapper (ORM) for Python that uses the Twisted library to provide asynchronous DB interaction.
http://findingscience.com/twistar
Other
132 stars 38 forks source link

... #73

Closed sehoffmann closed 7 years ago

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 85.872% when pulling a46d8184285c03009184515968ea29e9df875a3a on Paranaix:master into 19f4ce3d759f03f5066dfbaf2dab3f8939e6719d on bmuller:master.

bmuller commented 7 years ago

Thanks for this! I think the only thing that I'm not sure should be changed is updating each class to extend object. I'd like to update this to Python3 and stop supporting 2, in which case those changes would have to be reverted.

sehoffmann commented 7 years ago

Sorry this was not meant to be a PR. I actually just wanted to merge back the most recent commits into my fork, but somehow i failed.

However you might be interessted in my most recent commit (https://github.com/Paranaix/twistar/commit/06151f9d50a081788f991691be3c0e6959ffffc7) which adds real transactions (...which don't block the freaking main thread).

In the next days i will add SAVEPOINT support so you might want to wait before opening a PR.

PS: Please don't drop Python2 support or is there any important reason?