search

bmuller / twistar

Twistar is an object-relational mapper (ORM) for Python that uses the Twisted library to provide asynchronous DB interaction.
http://findingscience.com/twistar
Other
132 stars 38 forks source link

Proper transactions #74

Open sehoffmann opened 7 years ago

sehoffmann commented 7 years ago

As promised: Transactions which actually run in db threads. Supports fake nesting, SAVEPOINTs and can be used as context managers.

bmuller commented 7 years ago

Hey @Paranaix - thanks for the contribution! I'd be happy to merge, but I think the tests on CI are failing with these changes (though at first glance, I think it's just a linting issue).

sehoffmann commented 7 years ago

Sorry for the late reply, I was kind of the busy.

I already fixed this; however I ammended the commit and did a force push. Unfortunately travis CI doesn't seem to recognize the new commit. If you take a look at the travis build you will see that it still shows 5508348 and not 8310e31.

You can checkout the PR yourself and run the tests manually and they should pass IIRC.

bmuller commented 7 years ago

Hey @Paranaix - I think there are still a few issues. For instance this line still imports twisted.internet.reactor which isn't used.

sehoffmann commented 7 years ago

Ok, I'll have another look at it today or tommorrow