search

bmun / huxley

Conference management system for Berkeley Model United Nations.
http://www.bmun.org
BSD 3-Clause "New" or "Revised" License
37 stars 42 forks source link

Hotfixes #803

Closed srisainachuri closed 2 years ago

srisainachuri commented 2 years ago

fixing graded file link issues to delegate and advisor views + fixing null pointers for resubmitted graded papers

srisainachuri commented 2 years ago

LGTM. Not tested on stage.

Lots of reused code segments makes me think we can shove some parts of this into a react component on its own and pass the paper object and graded_files[paper.id] into the component.

Also I wonder what JS code convention is between the repeated gradedHrefData ? and a giant if {} block.

This is a good point. A lot of the reused code could be condense into a separate component since it probably reflects being written at different times. Will make an issue to work on this in the future.