Condense download graded paper buttons

bmun / huxley

Conference management system for Berkeley Model United Nations.

http://www.bmun.org

BSD 3-Clause "New" or "Revised" License

37 stars 42 forks source link

Condense download graded paper buttons #804

Open srisainachuri opened 2 years ago

srisainachuri commented 2 years ago

LGTM. Not tested on stage.

Lots of reused code segments makes me think we can shove some parts of this into a react component on its own and pass the paper object and graded_files[paper.id] into the component.

Also I wonder what JS code convention is between the repeated gradedHrefData ? and a giant if {} block.

Originally posted by @erwang01 in https://github.com/bmun/huxley/pull/803#pullrequestreview-893176148

srisainachuri commented 2 years ago

Main Code pointers: PaperGradeTable.js PaperSubmissionTable.js AdvisorPaperView.js

Condense the Download Paper menus in all of these into a single component.