search

bmuschko / gradle-cargo-plugin

Gradle plugin that provides deployment capabilities to local and remote containers via Cargo
Apache License 2.0
258 stars 61 forks source link

Fixed the unit test title for correct output description. #104

Closed willis7 closed 10 years ago

willis7 commented 10 years ago

A really pedantic change, sorry :-) I spotted this whilst looking at your project and how I can reuse your work around the ant logging listener.

bmuschko commented 10 years ago

The naming of the test case is actually correct as is. We only want to log if the log level is INFO. That's the case there. You can also see that the assert validates that the message is logged with Gradle's logger.

willis7 commented 10 years ago

The case in which I submitted the fix for is DEBUG where the test asserts there isn't a call, but the description states there is. See below:

void "Message logged for Cargo Ant task with debug priority"() {
...
then:
            0 * mockLogger.lifecycle('Cargo started')
bmuschko commented 10 years ago

Oh, never mind. I had a look at the wrong test case. Thanks!

willis7 commented 10 years ago

No problem, thanks for the code its very useful :-)