search

bmuschko / gradle-cargo-plugin

Gradle plugin that provides deployment capabilities to local and remote containers via Cargo
Apache License 2.0
258 stars 61 forks source link

Support for JBoss74x (aka EAP 6.3.x) container #105

Closed psiroky closed 10 years ago

psiroky commented 10 years ago

I am not sure if the change in this single file is enough or not. Please let me know if there are some additional changes needed.

I am wondering, shouldn't the list of supported containers come directly from the particular cargo version? I have no idea if that is technically possible, but it would seem logical to let the underlying cargo version decide what containers it supports.

bmuschko commented 10 years ago

Thanks for the pull request. I don't think the Cargo library exposes a list of supported containers through its API. That would make sense though. Would you be interested in looking into this?

psiroky commented 10 years ago

Yes, I will look into it once I have few minutes.

bmuschko commented 10 years ago

@psiroky That would be great!

twferrell commented 10 years ago

Hi Benjamin, What version will this be in? I'd like to take advantage of EAP 6.3 as well. Can you push new version to jcenter() or let me know if it's possible for me to grab now somehow? Appreciate all your hard work on this plugin!! Thanks

bmuschko commented 10 years ago

@psiroky @twferrell Released with version 1.5.2.

bmuschko commented 10 years ago

@psiroky Did you have a chance to look into the API support?

psiroky commented 9 years ago

@bmuschko thanks for the remainder, I complete forgot about this :) I could not find an easy way to get the list of supported containers. I asked on Cargo's dev-list (just now) to see if I missed something or there indeed is not a programmatic way to get the list (at least in current version).

http://cargo.996258.n3.nabble.com/Getting-list-of-supported-containers-programatically-td19389.html

psiroky commented 9 years ago

The following code should retrieve the supported containers (they need to be on CP): ContainerFactory containerFactory = new DefaultContainerFactory(); containerFactory.getContainerIds();

I am not sure though if that could be drop-in replacement for Container enum. @bmuschko what do you think?

bmuschko commented 9 years ago

Yeah, that should work. The only thing the method does not provide is a descriptive name of the container but that's OK. Would you be interested in working on a pull request for this?