search

bmuschko / gradle-cargo-plugin

Gradle plugin that provides deployment capabilities to local and remote containers via Cargo
Apache License 2.0
258 stars 63 forks source link

Change Conventions to extend the cargo convention among many others. #181

Closed jutoft closed 5 years ago

bmuschko commented 5 years ago

Thanks for providing the pull request.

Some requests from my end:

  1. Can we please break up the pull request? This PR contains multiple concerns e.g. introduce Provider types, change to the build script etc. Let's start small by just making the changes to the build script.
  2. It looks like one of the tests failing. You'll have to fix it before we can merge.
  3. There are changes that will also be made by another outstanding pull request: https://github.com/bmuschko/gradle-cargo-plugin/pull/180. I'd like to get that merged first.
bmuschko commented 5 years ago

Hi, just checking in. Would you mind breaking up your pull request into different aspects? I merged https://github.com/bmuschko/gradle-cargo-plugin/pull/180 in the meantime.

jutoft commented 5 years ago

Hey.

Yes i would like to do so as soon as possible, but it will probably not be this week. It has been difficult to keep up with all the changes so now the pr have become a bit broken.

tir. 29. jan. 2019 18.52 skrev Benjamin Muschko notifications@github.com:

Hi, just checking in. Would you mind breaking up your pull request into different aspects? I merged #180 https://github.com/bmuschko/gradle-cargo-plugin/pull/180 in the meantime.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bmuschko/gradle-cargo-plugin/pull/181#issuecomment-458639815, or mute the thread https://github.com/notifications/unsubscribe-auth/AD71QoEqDflrpltoXqx_N_djqqsQXokaks5vIIptgaJpZM4aLgpC .

bmuschko commented 5 years ago

I understand. I suggest you start from scratch and break out small PRs that can be merged quickly. Thanks for your work!