search

bmuschko / gradle-cargo-plugin

Gradle plugin that provides deployment capabilities to local and remote containers via Cargo
Apache License 2.0
258 stars 61 forks source link

Gradle update #182

Closed jutoft closed 5 years ago

jutoft commented 5 years ago

I pulled out the gradle update from the rest of the code. It tried with Gradle version 5.1.1. Gradle version 5.1.1 does not work with the integration tests, gradle wants to cleanup up tomcat dir, but a websocket api file is locked so it can not.

bmuschko commented 5 years ago

I was hoping we could make changes one by one. Could we please break up this PR into smaller chunk and individual concerns? It will make it easier for me to review and understand why you want to make those changes.

  1. Upgrade of Cargo version
  2. Upgrade of Gradle version (and the necessary timeout rename)
  3. Upgrade of external plugins
  4. Introduction of new external plugins (not a big fan of some of the Nebula plugins as they pull in too many dependencies and assumptions)
  5. Some files have been renamed (why?)
jutoft commented 5 years ago

Created issues instead, we can discuss it before more time is used coding.