Closed yagotlima closed 5 years ago
Thanks for your pull request. Can you please also add a test case for this to DeployableIntegrationSpec?
Thanks for your pull request. Can you please also add a test case for this to DeployableIntegrationSpec?
Yes I can. I'll work on it.
So I was working on a "can deploy an ear file" test case when I realized it's gonna take longer than I thought initially.
I created a new class: DeployableEarIntegrationSpec
to run this test case because it doesn't fit well inside DeployableIntegrationSpec
Turns out I can't extend AbstractIntegrationSpec because it runs tomcat and tomcat doesn't support ear files.
Before I proceed I'd like to know what is expected from this test case?
or
The use case we are changing here is "Can deploy a deployable (WAR or EAR or something else) without the need to specify a context". So it's really irrelevant what the deployable is. You can just go with a WAR as part of the test case. At the moment Gradle would complain about it either way if the context isn't provided.
Sorry for taking so long. Pushed a new test case just now.
Thanks for your work. It has been merged.
I don't know if there is a reason for the "context" property being mandatory but my builds are working fine without it.
Since it prevents the deployment of artifacts other than war files I think it's better to make it optional.