Closed alitokmen closed 3 years ago
Hi:
Just curious when this will reach plugins.gradle.org?
Thanks, Dennis
On Tue, Dec 15, 2020 at 6:50 AM S. Ali Tokmen notifications@github.com wrote:
- Upgrade to Codehaus Cargo 1.8.3
- Travis uses Java 8, so set the source and target compatibility version to Java 8
You can view, comment on, or merge this pull request online at:
https://github.com/bmuschko/gradle-cargo-plugin/pull/204 https://mailtrack.io/trace/link/40a475de3efaa0eaf1948e8489cab59f88271d65?url=https%3A%2F%2Fgithub.com%2Fbmuschko%2Fgradle-cargo-plugin%2Fpull%2F204&userId=3240016&signature=14fa9b1ed7aece2f Commit Summary
- Travis uses Java 8, so set the source and target compatibility version to Java 8
- Upgrade to Codehaus Cargo 1.8.3
File Changes
- M README.md https://mailtrack.io/trace/link/dee635a8d986b4d7ffac563d8b511124f205389c?url=https%3A%2F%2Fgithub.com%2Fbmuschko%2Fgradle-cargo-plugin%2Fpull%2F204%2Ffiles%23diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5&userId=3240016&signature=29e2bfb8b5655717 (4)
- M build.gradle https://mailtrack.io/trace/link/72e81b74fe9d9cdc2aa408c26df6ad5faa639b1d?url=https%3A%2F%2Fgithub.com%2Fbmuschko%2Fgradle-cargo-plugin%2Fpull%2F204%2Ffiles%23diff-49a96e7eea8a94af862798a45174e6ac43eb4f8b4bd40759b5da63ba31ec3ef7&userId=3240016&signature=9140d78624a11ccd (4)
- M src/main/groovy/com/bmuschko/gradle/cargo/CargoBasePlugin.groovy https://mailtrack.io/trace/link/77cf4bc297418afa20b1b9bba0e5dd43c0a4b996?url=https%3A%2F%2Fgithub.com%2Fbmuschko%2Fgradle-cargo-plugin%2Fpull%2F204%2Ffiles%23diff-01afe90a28729340b47e1d2edf4bfc11cec241bee4c69be1edda4a5452b8b46b&userId=3240016&signature=69add62022738830 (2)
Patch Links:
- https://github.com/bmuschko/gradle-cargo-plugin/pull/204.patch https://mailtrack.io/trace/link/34154407ae6628dd4b3d747c308f60bc17e80588?url=https%3A%2F%2Fgithub.com%2Fbmuschko%2Fgradle-cargo-plugin%2Fpull%2F204.patch&userId=3240016&signature=85d7b3f4bce5e117
- https://github.com/bmuschko/gradle-cargo-plugin/pull/204.diff https://mailtrack.io/trace/link/89bedece97cc832a5910260b97ffc573ced4abc1?url=https%3A%2F%2Fgithub.com%2Fbmuschko%2Fgradle-cargo-plugin%2Fpull%2F204.diff&userId=3240016&signature=8bc4fd5f08ab721b
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://mailtrack.io/trace/link/101c79a6dccea8ee9d91c58de6176464db54b4a4?url=https%3A%2F%2Fgithub.com%2Fbmuschko%2Fgradle-cargo-plugin%2Fpull%2F204&userId=3240016&signature=63df705175048859, or unsubscribe https://mailtrack.io/trace/link/ad35a9832b53a84cc188dea5a6865470eaa4cb54?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABUGXHRRMEUKT73NJT3IUOLSU5SRPANCNFSM4U4LYGCQ&userId=3240016&signature=0301c1df6a4d1d9e .
Thanks for providing the pull request. I'll look at this soon.
@gesker Be aware that you can already change the default Cargo version, as described here.
Thanks, Benjamin.
And, thank you for a great plug-in. Gradle really should consider adopting your project as core plugin. It's that good and super useful.
Wishing you a very happy holiday season.
Dennis
Quaerite lux et sapientia: Favilla, candelas, et stellas.
On Wed, Dec 16, 2020, 20:45 Benjamin Muschko notifications@github.com wrote:
Thanks for providing the pull request. I'll look at this soon.
@gesker https://github.com/gesker Be aware that you can already change the default Cargo version, as described here https://github.com/bmuschko/gradle-cargo-plugin#configuring-the-cargo-version .
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bmuschko/gradle-cargo-plugin/pull/204#issuecomment-747185782, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABUGXHQVAEVWVKGZPWZ2NTLSVF5EPANCNFSM4U4LYGCQ .