search

bmuschko / gradle-clover-plugin

Gradle plugin for generating a code coverage report using Clover
Apache License 2.0
74 stars 49 forks source link

#158 upgraded gradle version to 7.6.4 and changes are comaptible to 8.x ve… #159

Closed shanki2502 closed 2 months ago

shanki2502 commented 2 months ago

As part of this PR below changes are done.

  1. upgraded plugin versions
  2. upgraded library versions
  3. upgraded gradle version to 7.6.4
  4. updated use of outputDir to classesDirectory.get().asFile
Alex-Vol commented 2 months ago

It seems that develocity plugin does not have publishAlways() method. Can you correct the build issue and update the PR.

shanki2502 commented 2 months ago

I have updated the PR, thank you for your quick response.

shanki2502 commented 2 months ago

@Alex-Vol could you please approve it again, so build can trigger.

shanki2502 commented 2 months ago

@Alex-Vol @marek-parfianowicz I have updated PR, kindly approve. I will be going on vacation from tomorrow, will update this PR once I am back if there is any comment left.

shanki2502 commented 2 months ago

@Alex-Vol @marek-parfianowicz linux build is in queue for more than 40 mins

Alex-Vol commented 2 months ago

mins

I may have to update the GitHub action to fix this. The build has not executed for more than a year so some updates may be required.

Perhaps the choice of Ubuntu 18 is too old and it needs a refresh

shanki2502 commented 2 months ago

@Alex-Vol should I change the workflow file to use 22.04.4 or will you update it?

Alex-Vol commented 2 months ago

@Alex-Vol should I change the workflow file to use 22.04.4 or will you update it?

If you can change it l can try running it. I am on vacation till September 20th so can't do it before then

shanki2502 commented 2 months ago

@Alex-Vol I have updated version to 22.04, 18.04 was removed in 2022.

Alex-Vol commented 2 months ago

Reset the gradle-wrapper.jar to the master branch and update the PR. This is the only blocking charge. If necessary I can update the JAR myself when I can after I get back from vacation.

Gradle wrapper JAR doesn't change much between releases so I believe it will just work

shanki2502 commented 2 months ago

@Alex-Vol can you approve and merge this PR?

Alex-Vol commented 2 months ago

@Alex-Vol can you approve and merge this PR?

If you reset the jar fike I will be able to merge it.

shanki2502 commented 2 months ago

@Alex-Vol can you approve and merge this PR?

If you reset the jar fike I will be able to merge it.

done, could you please approve and merge?

Alex-Vol commented 2 months ago

Made changes to master for the upload v2 issue and squash merged

Alex-Vol commented 2 months ago

I am away for an extended time and I am not sure when I can perform the new release ceremony. I will attempt it remotely although it is a bit complex. I did not bring a laptop to perform work like this with me.

On Mon, Sep 16, 2024, 9:57 AM shanki2502 @.***> wrote:

@Alex-Vol https://github.com/Alex-Vol can you approve and merge this PR?

If you reset the jar fike I will be able to merge it.

done, could you please approve and merge?

— Reply to this email directly, view it on GitHub https://github.com/bmuschko/gradle-clover-plugin/pull/159#issuecomment-2352141164, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJTZWPNEW4GQRMQPRIPE5LZWZ6MLAVCNFSM6AAAAABNOSLTRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJSGE2DCMJWGQ . You are receiving this because you were mentioned.Message ID: @.***>