search

bmuschko / gradle-clover-plugin

Gradle plugin for generating a code coverage report using Clover
Apache License 2.0
74 stars 49 forks source link

Support for Clover history and possibility to generate instrumented JARs #38

Closed abeggchr closed 7 years ago

abeggchr commented 11 years ago

Generate JARs with instrumened classes (https://github.com/bmuschko/gradle-clover-plugin/issues/35) Support for Clover history (https://github.com/bmuschko/gradle-clover-plugin/issues/5)

abeggchr commented 10 years ago

Hi Benjamin

I noticed some activity around the gradle-clover-plugin. Since I made my pull request some months ago I'd be glad to get some feedback. I know there are a lot of modifications, but there are also many days of work behind the pull request.

Cheers, Christian

By the way: I just got your Gradle book yesterday. Great stuff, thanks!

bmuschko commented 10 years ago

I appreciate the amount of work you put into it. Unfortunately, I haven't gotten around to look at it. I really feel bad about it as I know that it was time-intensive.

I believe the reason why I stayed away from it was because it's a big change. Big changes usually need a lot of review and testing. Would it be possible to break this up into smaller changes? I will try to look at it soon.

danielsuter commented 9 years ago

Have you planned to merge this commit? It contains pretty good features and bug fixes. I had to merge them on my own.

bmuschko commented 9 years ago

@danielsuter It's such a big change that I kept putting it in my backlog. I'd love to have it but I will need to reserve at least 2-3 hours for this. Just merging usually doesn't do. It's the polishing that takes most of the time.

@abeggchr I am very sorry this hasn't been merged yet. Would you mind rebasing your pull request?

Alex-Vol commented 7 years ago

This is a very old pull request. The only solution is to review the changes and implement them from scratch on the new code base. I will attempt to do this in my spare time. I have managed to address the majority of reasonable requests and known issues. All other pull requests have been cleared and committed.

Alex-Vol commented 7 years ago

I believe working out how to make this into a set of working commits is worth the time. It would address the following issues:

Alex-Vol commented 7 years ago

Implemented history feature in a separate pull request without difficulty. The implementation extends the existing task instead of a new task and works well. I will release it in the 2.1.1 milestone.

Closing this PR, all important features have been handled.