support for encoding taken from nearest compiler.

bmuschko / gradle-clover-plugin

Gradle plugin for generating a code coverage report using Clover

Apache License 2.0

74 stars 49 forks source link

support for encoding taken from nearest compiler. #45

Closed phasebash closed 10 years ago

phasebash commented 10 years ago

This is an attempt to pull the encoding and executable from the nearest compiler configuration (in a non-deprecated way).

bmuschko commented 10 years ago

Thanks for the pull request. I just had a quick look. Instead of trying to find a sensible default, we could just expose the encoding property through the DSL. If it's not set (meaning its value is null), then we don't set the encoding for the compiler. If it is set, then we set it. That would remove a lot of code and make the pull request simpler. Then it's up to the user set a value from the outside. Would you be willing to modify your pull request?

phasebash commented 10 years ago

Sure, if that is what you'd prefer. I'll close this request and will issue a new one soon, ideally tomorrow.