search

bmuschko / grails-google-visualization

Grails plugin that provides a taglib for the interactive charts of the Google Visualization API
http://www.grails.org/plugin/google-visualization
Other
25 stars 42 forks source link

google-visualization plugin vs. Grails 2.1.0-RCs #5

Closed tviel closed 12 years ago

tviel commented 12 years ago

Hi Benjamin,

I really appreciate your work on the google-visualization plugin. It is not very often, that plugins get maintained that actively.

I just came to the situation, using grails 2.1.0-RC3 together with your plugin. My project gets build using maven, and if you're interested in the pom, you can find the dependency part attached. Starting the app fires up an error:

Compilation error: startup failed: /Users/tviel/Projects/wootledo/com.wootledo/plugins/google-visualization-0.5.3/grails-app/taglib/org/grails/plugins/google/visualization/GoogleVisualizationTagLib.groovy: 170: Mixing private and public/protected methods of the same name causes multimethods to be disabled and is forbidden to avoid surprising behaviour. Renaming the private methods will solve the problem. @ line 170, column 5. private validateAttributes(attrs, googleVisualization) { ^

/Users/tviel/Projects/wootledo/com.wootledo/plugins/google-visualization-0.5.3/grails-app/taglib/org/grails/plugins/google/visualization/GoogleVisualizationTagLib.groovy: 178: Mixing private and public/protected methods of the same name causes multimethods to be disabled and is forbidden to avoid surprising behaviour. Renaming the private methods will solve the problem. @ line 178, column 5. def validateAttributes(attrs, googleVisualization, optionalAttributes) { ^

2 errors

I would be pleased supporting you in testing if you'd like.

BRegards Thorsten

tviel commented 12 years ago 

  2.1.0.RC3




    
    org.grails
    grails-dependencies
    ${grails.version}
      pom
  

  
      org.grails
      grails-plugin-testing
      ${grails.version}
      test
      

  
      org.grails.plugins
      tomcat
      ${grails.version}
      zip
      provided
  

  
      org.grails.plugins
      jquery
      1.7.1
      zip
      runtime
   

  
      org.grails.plugins
      resources
      1.1.6
      zip
      runtime
   

  
      org.grails.plugins
      database-migration
      1.1
      zip
      runtime
  

    
        org.grails.plugins
        rest-client-builder
        1.0.2
        zip
        runtime
    
    
        org.grails.plugins
        google-visualization
        0.5.3
        zip
        runtime
bmuschko commented 12 years ago

Thanks. I am glad it's helpful.

That should be an easy fix. Personally, I don't get the compilation error. I am building the project with Grails 2.0.1. It could be that 2.1.0 already has a newer Groovy version packaged which has stricter compilation rules.

I just deleted some old code which should fix the issue. Can you do me a favor and test it quickly before I release it? You can probably just add it as a inplace plugin to your project.

bmuschko commented 12 years ago

I released a new version that shouldn't cause a compilation error anymore: v0.5.4. I am going to close this issue for now. Should this issue will occur please reopen the ticket.