search

bmusuko / shortener

https://shortener-nu.vercel.app
0 stars 4 forks source link

Added hit rate feature #5 #9

Closed kandarppatel28 closed 4 years ago

kandarppatel28 commented 4 years ago

Added a new field visitCount to db schema and increment it on each link visit, as mentioned in #5

vercel[bot] commented 4 years ago

@kandarppatel28 is attempting to deploy a commit to a Personal Account owned by Bram Musuko Panjaitan on Vercel.

@bmusuko first needs to authorize it.

bmusuko commented 4 years ago

LG

kandarppatel28 commented 4 years ago

Hay @bmusuko , Its my pleasure to contribute, I request you if you can add "Hactoberfest" into your repo topic, because without it the repo is considered invalid, Thank you in advance. :)

bmusuko commented 4 years ago

Sorry for the late response, I've added the Hacktoberfest tag. As far as I know, we don't need any tag to be considered valid, as long as we create a pull request to any public repository CMIIW

kandarppatel28 commented 4 years ago

Thank you @bmusuko , but unfortunately it still shows invalid repo, yes you are right, but they have recently changed their rules and regulations, you can check it out on https://hacktoberfest.digitalocean.com/hacktoberfest-update

kandarppatel28 commented 4 years ago

I got it, you got a typo there, correct "hactoberfest" to "hacktoberfest", after that you will be good to go

bmusuko commented 4 years ago

I'm so sorry, I just copy your tag earlier lol. I've changed the label to hacktoberfest, can you confirm your PR already valid? @kandarppatel28

kandarppatel28 commented 4 years ago

Oh, that's my bad, yes @bmusuko no the PR is valid! Thank you! Happy Hacking!!! Any thoughts regarding the implementation of the dashboard, for displaying visit count?