search

bmvantunes / youtube-2020-june-multi-step-form-formik

A repository with a multi-step form using Formik, Yup and Material-UI
https://youtu.be/l3NEC4McW3g
MIT License
100 stars 68 forks source link

Improve typing for FormikStepper #8

Closed VdeVentura closed 2 years ago

VdeVentura commented 3 years ago

Hello!

Thank you for the great approach on doing multi step forms with formik,

I was playing around with it and noticed that we lost the type definitions for the initial values when we use the FormikStepper compared to using Formik directly, so I copied the interface of Formik over to FormikStepper.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bmvantunes/youtube-2020-june-multi-step-form-formik/2p3dlstqw
✅ Preview: https://youtube-2020-june-multi-step-form-formik-git-master.bmvantunes.vercel.app

bmvantunes commented 3 years ago

I really really appreciate your work here my friend =) Thank you very much! :)

Usually I try to keep the repository as similar to the original video as possible to help people following along during the video.

That being said, I would really love to have this here in the repo in a different branch if possible? Are you OK with having this in a different branch called something like "better-types" (I'm very bad in naming stuff xD)?