search

bmw-software-engineering / lobster

Lightweight Open BMW Software Traceability Evidence Report
GNU Affero General Public License v3.0
12 stars 6 forks source link

improve accessibility in LOBSTER html report #34

Open ankushsonare1 opened 4 months ago

ankushsonare1 commented 4 months ago

improve accessibility in LOBSTER report: HTML report #26

As a maintainer of the LOBSTER tool

I change prominent colours.

So that visually impaired people (color blindness) can distinguish easily between error and success

mugdhadhole1 commented 2 months ago

Colors seems ok Ok to merge

phiwuu commented 2 months ago

The new images look very nice.

phiwuu commented 2 months ago

Please clarify the copyright of the new icons. If we are OK to use them, then please update the colours as follows:

  1. use a darker green instead of light green, e.g. b2e1b2
  2. change red to purple, e.g. ffb2ff
  3. keep the gray as is
phiwuu commented 2 months ago

I saw your comment, but I don't get the point. What do you mean with "not intuitive"? The color changes are minimal, but solve the issue for visually impaired people. Adding a command-line flag or javascript is much more effort compared to changing the colors. We want to close this issue and move on.

ankushsonare1 commented 1 month ago

I have check new svg icons its not copyright.

florianschanda commented 1 month ago

Traffic light colours are universally clear. The proposed colours are not - you need to add a legend at the very least.

phiwuu commented 1 month ago

Traffic light colours are universally clear. The proposed colours are not - you need to add a legend at the very least.

That's a fair point.

florianschanda commented 1 month ago

I would still strongly argue for a command-line option if a live, in document option using JS is too hard to do. It won't be too hard to do given how we bake in the style sheet anyway.

christophkloeffel commented 13 hours ago

please also create an entry in the changelog