search

bmw-tech / atlas

An Extensible Map Abstraction for Flutter
https://bmw-tech.github.io/atlas/
MIT License
110 stars 19 forks source link

removed onTap from the == comparer (Marker object) #133

Closed oguibueno closed 2 years ago

oguibueno commented 2 years ago

When comparing functions from different object instances, they will never be the same.

issue reference: https://stackoverflow.com/questions/16875895/dart-member-function-equality-rules

codecov-commenter commented 2 years ago

Codecov Report

Merging #133 (a50fff6) into master (4e04d31) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #133    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           24         4    -20     
  Lines          393       146   -247     
==========================================
- Hits           393       146   -247
Flag Coverage Δ
atlas ?
google_atlas 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/atlas/lib/src/marker.dart
packages/atlas/lib/src/marker_icon.dart
packages/atlas/lib/src/camera_position.dart
packages/atlas/lib/src/polygon.dart
packages/atlas/lib/src/map_language.dart
packages/atlas/lib/src/screen_coordinate.dart
packages/atlas/lib/src/atlas.dart
packages/atlas/lib/src/atlas_provider.dart
packages/atlas/lib/src/lat_lng_bounds.dart
packages/atlas/lib/src/rectangle_2d.dart
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e04d31...a50fff6. Read the comment docs.