search

bmwcarit / Emma

Emma Memory and Mapfile Analyser. (Repo marked private after security audit. Contact Marian Kneer for details)
GNU General Public License v3.0
4 stars 0 forks source link

Issue #5 memory manager redesign #10

Closed holzkohlengrill closed 4 years ago

holzkohlengrill commented 4 years ago

Description tacked in #5

holzkohlengrill commented 4 years ago

https://github.com/bmwcarit/Emma/tree/ISSUE_%235_MemoryManagerRedesign/tests/other_files

iIs not longer needed. Please remove (@KGergo88 ).

KGergo88 commented 4 years ago

https://github.com/bmwcarit/Emma/tree/ISSUE_%235_MemoryManagerRedesign/tests/other_files

iIs not longer needed. Please remove (@KGergo88 ).

Since the CI tools only generate such results for the master, it is indeed needed.

holzkohlengrill commented 4 years ago

https://github.com/bmwcarit/Emma/tree/ISSUE_%235_MemoryManagerRedesign/tests/other_files iIs not longer needed. Please remove (@KGergo88 ).

Since the CI tools only generate such results for the master, it is indeed needed.

Therefore you can create a pull request and see the results.

KGergo88 commented 4 years ago

https://github.com/bmwcarit/Emma/tree/ISSUE_%235_MemoryManagerRedesign/tests/other_files iIs not longer needed. Please remove (@KGergo88 ).

Since the CI tools only generate such results for the master, it is indeed needed.

Therefore you can create a pull request and see the results.

I would prefer to keep this script.

KGergo88 commented 4 years ago

Drive c on linux will probably not work :-) Can't this be done with relative paths?

Fixed in: 1c845d0

KGergo88 commented 4 years ago

@holzkohlengrill The remaining 6 Codacy issues are only the subprocess calls in genDoc. I will not waste time on solving them. Please try to ignore them in Codacy somehow.

KGergo88 commented 4 years ago

@holzkohlengrill The code duplications in the unit tests are also worth the time to investigate them. Some of them are also false positives. Please ignore the "tests" folder regarding duplications.

KGergo88 commented 4 years ago

@holzkohlengrill The Travis build is failing because of the issue #11. See unit test "test_noMemStats". Please implement a solution for this issue.

KGergo88 commented 4 years ago

@holzkohlengrill: All points were implemented. Can I merge into master?