search

bmwcarit / python-dlt

python-dlt is a thin Python ctypes wrapper around libdlt functions
Mozilla Public License 2.0
34 stars 29 forks source link

2.18.6 #29

Closed blublup closed 1 year ago

blublup commented 3 years ago

Updates for dlt-daemon 2.18.6 compatibility.

yen3 commented 3 years ago

@blublup HI, thanks for your pr.

Could you add the commit https://github.com/yen3/python-dlt/commit/05529817d2b1616a487c42491ee44e9e1c73106b ? With the patch, we could test python-dlt for the current version and 2.1.8.6. Then we could discuss how to make all tests pass.

Thank you.

yen3 commented 3 years ago

I try to mention some problems. After these problems are fixed, we could discuss how to process the PR.

Thanks for your contribution. :)

yen3 commented 3 years ago

@blublup hi, do you want to continue to fix the patch?

LocutusOfBorg commented 3 years ago

Hello @yen3 I think I took care of the changes in https://github.com/bmwcarit/python-dlt/pull/34

yen3 commented 3 years ago

@LocutusOfBorg Thanks for your help and contribution. I will review it.