search

bmwinstead / enigma-project

Other
1 stars 1 forks source link

Ensure historic Enigma machine compliance. #1

Closed bmwinstead closed 11 years ago

bmwinstead commented 11 years ago

Title.

bmwinstead commented 11 years ago

Three rotor configs are good. So are four rotor configs, HOWEVER... the parameters on the methods are confusing for four rotor config. The fourth rotor parameter is in the fourth spot, which makes sense... except the fourth rotor is the left-most rotor, and the other rotors are in order. So conceptually you want to pass parameters like {1,2,3,4}, with 1 being the left-most and 4 being the right-most, but you have to pass them {2,3,4,1} as it is. This is obviously bad, so need to redesign so parameters are in line with expectations. I'll take a few minutes and do tomorrow.