bmwinstead / enigma-project

Other
1 stars 1 forks source link

Bug/Feature: CA GUI: Decryption will not complete with invalid plugboard input #38

Closed EOhlmacher closed 10 years ago

EOhlmacher commented 10 years ago

Steps to reproduce:

  1. Launch the Enigma GUI
  2. Switch to the Cryptanalysis GUI Tab 3.Enter text OLPF
  3. Enter Plugboard settings $3R9
  4. Press "Decrypt"

Observed result: Program stops running at 729 of 872. Task manager shows no CPU use.

Expected result: We should probably drop invalid input from the plugboard entry box.

wadolph commented 10 years ago

Added checks to not allow a decryption to start with invalid characters in the decrypt box and the plugboard entry area, with error messages to display the issue. Awaiting retest.

EOhlmacher commented 10 years ago

I don't see this change. Did we have another GitHug incident?

EOhlmacher commented 10 years ago

I see it now! Looks great!