search

bmx-ng / bcc

A next-generation bcc parser for BlitzMax
zlib License
33 stars 13 forks source link

[Misc] Replace TStringBuffer with Brl.StringBuilder #612

Closed GWRon closed 1 year ago

GWRon commented 1 year ago

Brl.StringBuilder now contains all the logic of "stringbuffer_***.bmx". So it could be replaced and would automatically benefit from bugfixes and enhancement in brl.StringBuilder.

Disadvantage: requires brl.stringbuilder (dunno if "vanilla" is still something which should be able to compile bcc)

woollybah commented 1 year ago

As you say, removing this means you can no longer build bcc with "legacy" BlitzMax.

GWRon commented 1 year ago

This is why I put up the question if you want to still support building with legacy bcc.

And more important: are you building it in legacy from time to time? Am not sure if it does as I did not try for years. So possibly the only vanilla/legacy based bcc builder is HurryStarfish ;-).

But yeah. Maybe we should keep it in. But then we need to ensure to have it updated to brl.stringbuilder code base in case of bugfixes there.

Fyi: i replaced some string building with stringbuilder stuff but it did not bring that much on building time.