search

bmx-ng / bmx-site

BlitzMax website source
3 stars 7 forks source link

Adding Discord-chat-links #38

Closed GWRon closed 4 years ago

GWRon commented 4 years ago

Uploading the image to here allows to directly use it on the website.

613699895139762176

613699895139762176 (1)

I would like to add a chat-link to the website displaying current amount of users - similar to the github stars.

GWRon commented 4 years ago

I propsed it via a Pull-Request but to make it complete I post it here too:

            <a
              href="https://discord.gg/udSSJkj"
              target="_blank"
              rel="noreferrer noopener">
              <img src="https://user-images.githubusercontent.com/2625226/75874927-076a0680-5e13-11ea-9c63-5de88624df6d.png"
                   alt="Chat on Discord"
                   data-canonical-src="https://img.shields.io/discord/613699895139762176.svg?logo=discord&color=DDDDDD&logoColor=555555&style=social" style="max-width:100%;"
              >
            </a>
woollybah commented 4 years ago

So, something like this then...

Discord

<a href="https://discord.gg/udSSJkj" target="_blank" rel="noreferrer noopener">
    <img alt="Chat on Discord" src="https://img.shields.io/discord/613699895139762176?logo=discord&style=social"/>
</a>
GWRon commented 4 years ago

Yes ... but the link there is using a PNG as default and the canonical url is the actual url to use (an svg).

Edit: I bluntly copied that from raylib and they for sure do it that way for a reason.

Edit2: I think it has also to do with where the image is coming from - the first one is from the same site (github stuff) while the second one would be an external image.