search

bmx-ng / sdl.mod

SDL backend for BlitzMax
7 stars 6 forks source link

Fix: [SDL.mod] call bbThreadUnregister for SDL_Threads (regression) #61

Closed GWRon closed 7 months ago

GWRon commented 7 months ago

Seems the Commit adding 2.28.0 missed to call bbThreadUnregister(bbThread) as the prior version (modded...) did.

Edit: The indentation of the code is copied from the previous version of the file - just if you wonder (and it corresponds to the indentation of the bbThreadRegister-call - to emphasize "blitzmax changes" in the file)

Fixes #58

GWRon commented 7 months ago

That this bug/crash has been unseen/unmentioned for months despite by me .. is very odd. Seems people are not using threads so much.

Might be a good idea to have a file in the repo (within sdl.mod) telling what changes were made by "us". This would help updating libs and reapplying customizations. Same for other libraries having customizations. Eg this could be a "blitzmaxng.patch" file containing a "patch" between original lib code and "blitzmax ng" code. Or at least a kind of documentation file.