Closed smoe closed 6 years ago
I have the impression you committed d8869ec erroneously [...]
I hope I just fixed that. Please remove the commit from your PR as it's merged to the debian branch.
Do you have suggestions for me how to perform a test?
I'll do some tests with a router and a VM once this is merged. I could send you the commands I use if you're interested to do the same.
How likely is it that users have bmx6 and bmx7 installed on the same machine? Should the package rather be called bmx with version 6 / 7?
Very, both versions aren't compatible with one another. While 7 is the planned successor, BMX6 is still heavily used as it has no crypto lib dependencies making it (easier) usable on small (legacy) 4MB flash routers.
I saw you're excluding the uci plugin, I'd suggest to do the same with iwinfo.
I just removed some long text stating that I would not know how to remove your commit without a rebase or you merging with master what has been commited already. To keep it short, please kindly rename/delete the current debian branch and craft me a new one.
To keep it short, please kindly rename/delete the current debian branch and craft me a new one.
Done
Funnily enough the prior pull request was not removed. Looks good now. I suggest you accept the patch and then improve the description in the debian/control file. I did not come across an iwinfo module for bmx6, just whatever additinional negative selector that may be required.
I did not come across an iwinfo module for bmx6, just whatever additinional negative selector that may be required.
My bad, it's a BMX7 only feature :)
improve the description in the debian/control file.
@axn are you up for that?
If not done already, I'll amend control file and add tags till Monday. But feel free to advance here as well. Any suggestions for a versioning scheme that facilitates frequent (interoprrable) updates? thanks for good progress
(Accidentally commented to #13 first)
Hello,
I have the impression you committed d8869ec erroneously to the https://github.com/bmx-routing/bmx6/tree/debian branch you just created. Before pressing any accept button, you may want to perform a merge https://github.com/bmx-routing/bmx6/tree/debian with master to get that patch out of the way and then only have pristine Debian-only changes maintained in that branch.
So, following our mission outlined in https://github.com/bmx-routing/bmx6/issues/13 I have the package in a state that looks reasonably fine. Please help me in debian/control with
I still need to have a look at your source code to learn how you import the modules. Until then I have spared the ldconfig in the (now non-existing) post-install script. I have also changed the directory to /usr/lib/bmx6 instead of having all libraries in /usr/lib directly. This likely needs a respective adjustment in the main source tree that I have not yet addressed, your feedback pending.
You will happily observe a man page. That was auto-created and then somewhat manually optimized for the impression I got with "nroff -man debian/bmx6.1". Please also have at look at that.
Do you have suggestions for me how to perform a test? How likely is it that users have bmx6 and bmx7 installed on the same machine? Should the package rather be called bmx with version 6 / 7?
Best,
Steffen