search

bmx-routing / bmx6

BMX6 Mesh Networking Protocol
http://bmx6.net
56 stars 26 forks source link

Fix tablePrefTuns, tableTuns and throwRules options. #2

Closed sim6 closed 12 years ago

sim6 commented 12 years ago

http://bmx6.net/issues/137 http://bmx6.net/issues/144

axn commented 12 years ago

Hi Simó

Thanks a lot for your fixes. Good job. Actually I always wondered why throw routes showed no effect in IPv6. Now I know that they need an interface.

As far as I could quickly see from your patches, there is one minor problem with the second one. The loopback device does NOT always have dev_idx=1 !! For example if you use LXC for virtualization, then you have one lo per container with a higher idx. As soon as I find time to fix that I'll pull the patches.

/axel

On 27.04.2012 14:36, Simó Albert i Beltran wrote:

http://bmx6.net/issues/137 http://bmx6.net/issues/144

You can merge this Pull Request by running:

git pull https://github.com/sim6/bmx6 master

Or you can view, comment on it, or merge it online at:

https://github.com/axn/bmx6/pull/2

-- Commit Summary --

  • Fix tablePrefTuns and tableTuns options, closes #137.
  • Fix throwRules option, closes #144.
  • Add Simó Albert i Beltran as contributor on ip.c.

-- File Changes --

M ip.c (12)

-- Patch Links --

https://github.com/axn/bmx6/pull/2.patch https://github.com/axn/bmx6/pull/2.diff

Reply to this email directly or view it on GitHub: https://github.com/axn/bmx6/pull/2

axn commented 12 years ago

Hi Simó

I tested and merged your fixes and also commited a patch that uses the right loopback idx for ipv6 even when it is not "1".

But in general, if we can avoid, we should not use throwRules=1 option for bmx6. In the long term I'd like to implement what we discussed on the roof last saturday.

Thanks anyway /axel

On 27.04.2012 14:36, Simó Albert i Beltran wrote:

http://bmx6.net/issues/137 http://bmx6.net/issues/144

You can merge this Pull Request by running:

git pull https://github.com/sim6/bmx6 master

Or you can view, comment on it, or merge it online at:

https://github.com/axn/bmx6/pull/2

-- Commit Summary --

  • Fix tablePrefTuns and tableTuns options, closes #137.
  • Fix throwRules option, closes #144.
  • Add Simó Albert i Beltran as contributor on ip.c.

-- File Changes --

M ip.c (12)

-- Patch Links --

https://github.com/axn/bmx6/pull/2.patch https://github.com/axn/bmx6/pull/2.diff

Reply to this email directly or view it on GitHub: https://github.com/axn/bmx6/pull/2