search

bmx666 / android-appcachecleaner

Android Cache Cleaner
GNU Affero General Public License v3.0
444 stars 32 forks source link

F-Droid can't build #210

Closed licaon-kter closed 1 month ago

licaon-kter commented 7 months ago

https://gitlab.com/fdroid/fdroiddata/-/jobs/6348557804#L860

look like your APK in https://github.com/bmx666/android-appcachecleaner/releases/tag/v1.10.11 was NOT built from the tagged commit bb00c8620f947f940f2a96b8c3d362c109eced3f

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/7dfcccb5ba515729ed031671fb6639c276cc3398

bmx666 commented 7 months ago

Hi @licaon-kter

Thanks for update, hmm, strange, but anyway I checkout on v1.10.11, rebuilt APK again and re-uploaded into release. https://github.com/bmx666/android-appcachecleaner/releases/tag/v1.10.11

P.S. ah, it shows release was made from #209 of developer branch - f391935c90f83f704aaf03ef6eaa974c89898fbb

Thanks again for highlighting! Now everything should be ok

licaon-kter commented 7 months ago

that's better https://gitlab.com/fdroid/fdroiddata/-/jobs/6349948252#L919

reenabled: https://gitlab.com/fdroid/fdroiddata/-/commit/066b339c80b5b6696e2f5d51654ae1ccbae3b955

licaon-kter commented 1 month ago

and again: https://gitlab.com/fdroid/fdroiddata/-/jobs/7648835805#L1558

diff log: appcl93.log.zip

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/08288978f9f37d4579e1936113ac8d5af999762a

bmx666 commented 1 month ago

Hi @licaon-kter , thanks for update. It seems that Android Studio isn't rebuilding or regenerating new APK binaries, even after switching to a different commit with identical changes. Nevertheless, I performed a clean rebuild and uploaded a new APK. I will ensure to make a clean rebuild before uploading future releases. Sorry for the inconvenience.

licaon-kter commented 1 month ago

Thanks

bmx666 commented 1 month ago

I created an issue on Google Issue Tracker -> https://issuetracker.google.com/issues/361746103 I hope someone can explain this behavior.

licaon-kter commented 1 month ago

hmm, https://gitlab.com/fdroid/fdroiddata/-/jobs/7852041468#L2332 can you reopen?

/LE: see link below

bmx666 commented 1 month ago

Google recently add compose-compiler, I did clean release build as before, I have no idea why F-Droid throws error. But from log it's related to classes.dex diff.

licaon-kter commented 1 month ago

diff log: cache101.log

bmx666 commented 1 month ago

I upload new clean release build again, it's the same...

bmx666 commented 1 month ago

Here new patch that includes compose-compiler from Google https://github.com/bmx666/android-appcachecleaner/commit/372656cebec22974cd1a8b797da448fa898dad77

bmx666 commented 1 month ago

I will update Android Studio and SDK manager and re-upload new clean release APK

bmx666 commented 1 month ago

I made a new release - https://github.com/bmx666/android-appcachecleaner/releases/tag/v2.2.4 Full clean rebuild, let's see it F-Droid will throw the same error.

bmx666 commented 1 month ago

There is another possible issue could be - https://developer.android.com/build/releases/gradle-plugin#groovy

Caution: You should not use dynamic dependencies in version numbers, such as 'com.android.tools.build:gradle:8.6.+'. Using this feature can cause unexpected version updates and difficulty resolving version differences.

Time to release a new release...

bmx666 commented 1 month ago

@licaon-kter Sorry for the mess, Google never lets developers stay chill... 😞 https://github.com/bmx666/android-appcachecleaner/releases/tag/v2.2.5

licaon-kter commented 1 month ago

verified locally, thanks, https://gitlab.com/fdroid/fdroiddata/-/commit/97c9cbc82535a916194714d30e924897d7318c8b