search

bn0 / check_dcm

Nagios/Icinga plugin to check DICOM service
4 stars 3 forks source link

pyhton3 compatibility #1

Open luc-ass opened 3 months ago

luc-ass commented 3 months ago

Hi @bn0,

First of all thank you for whipping up this nagios plugin. I wondered whether you accept pull requests. As our monitoring server is using a newer distribution of Ubuntu, I would like to use python3, which this plugin is not compatible with. If you are still monitoring this, I would create a pull request with my changes.

You can have a look at it here: https://github.com/luc-ass/check_dcm/commit/c13e5aa21ef1c8348eb301fb202b4688ea697dce

Cheers, Lucas

bn0 commented 3 months ago

Hi @luc-ass,

Sorry for the late reply, your code looks good to me (I probably should have done this a long time ago!). Make a PR and I will merge it :)

luc-ass commented 3 months ago

👍 I am still running production test, but I will make the pull request as soon as I feel it's ready.