search

bnagy / gapstone

gapstone is a Go binding for the capstone disassembly library
Other
151 stars 43 forks source link

move trampoline outside of engine.go where it is used #10

Closed StalkR closed 9 years ago

StalkR commented 9 years ago

While gapstone compiles fine with gc, I noticed it doesn't work gccgo. I reported it to the Go team at https://github.com/golang/go/issues/9294 and it turns out we can't declare trampoline() and use it within the same file because of a chicken and egg problem. The solution is to move the declaration of trampoline into its own file, then it compiles both with gc and gccgo.

bnagy commented 9 years ago

LGTM but I'm still hungover from kiwicon so I'll double check and merge in a day or two. Thanks!