Make gapstone go-get-able without pre-installing Capstone.

bnagy / gapstone

gapstone is a Go binding for the capstone disassembly library

Other

151 stars 43 forks source link

Open BenLubar opened 6 years ago

BenLubar commented 6 years ago

Also fixes tests failing on Windows due to line endings in .SPEC files.

Tested on Windows 10 (mingw-gcc 5.3, Go 1.11beta2) and Ubuntu 18.04 (gcc 7.3, Go 1.10.3).

bnagy commented 6 years ago

Hi! Thanks for the code. If you can fix the CI errors then I'm OK to merge this. Looks like it's just breaking on old go?

knightsc commented 5 years ago

@bnagy Looking at the build errors I see this

The command "eval go get -t -v ./... " failed. Retrying, 2 of 3.

It seems like maybe Travis CI just had some connectivity issues. Would you be able to retry the build and see if it builds and tests cleanly?

I think this PR is a nice improvement and would be in favor of merging it.