search

bnalls33 / MockMockLocations

XPosed Module Preventing Apps from Detecting "Allow mock locations" setting.
74 stars 17 forks source link

add support for API level >= 18 #2

Closed fangdingjun closed 8 years ago

fangdingjun commented 8 years ago

At API level 18, a new function Location.isFromMockProvider is added for detect mock location

bnalls33 commented 8 years ago

Hi fangdingjun, thanks SO much for your contribution. I have two comments on the code. It seems like we should do both operations for all users. Even if APIs are deprecated, some developers use deprecated methods so we need to guard those calls.

fangdingjun commented 8 years ago

I update the code, please review it.

Actually, the code metioned in your second comment do not apply for all version, because the if block has a return statement.

bnalls33 commented 8 years ago

Thank you! Didn't see the premature return statement