bnb-chain / bep3-deputy

GNU Lesser General Public License v3.0
12 stars 19 forks source link

Kava executor upgrade for mainnet #2

Closed denalimarsh closed 4 years ago

denalimarsh commented 4 years ago

This PR contains upgrades required for Kava mainnet.

  1. Kava's mainnet has dependencies on v0.33.3 tendermint and v0.38.3 cosmos-sdk. Since both are pre-v1.0, they're incompatible with the versions used by the binance-chain/go-sdk. The updates to go.mod and go.sum resolve these incompatibilities and allow both go-sdks to be imported by the bep3-deputy.

  2. Kava executor upgraded to v0.33.3 tendermint, v0.38.3 cosmos-sdk, and the kava-labs/go-sdk@latest. Changes include updated imports (cmn -> tmbytes), updated block/blockresults attribute parsing, and deprecating BlockMeta.

  3. Kava executor updated to reflect Kava latest. Amongst other changes, MsgCreateAtomicSwap no longer includes the fields ExpectedIncome and CrossChain.

  4. As the result of an internal audit, a potential attack vector in the Kava Executor has been mitigated by enhanced swap ID parsing.