search

bnb-chain / bsc-relayer

An implementation of relay service to relay cross chain packages from BNB Beacon Chain to BNB Smart Chain
GNU Lesser General Public License v3.0
101 stars 51 forks source link

unconfirmed_tx_threshold of Binance Smart Chain should be larger than 0 #32

Closed tdiesler closed 3 years ago

tdiesler commented 3 years ago

With the v1.1.0 default config, I see ...

unconfirmed_tx_threshold of Binance Smart Chain should be larger than 0
...
goroutine 1 [running]:
github.com/binance-chain/bsc-relayer/config.(*BSCConfig).Validate(0xc0000da2a0)
    /opt/app/config/config.go:122 +0x24c
github.com/binance-chain/bsc-relayer/config.(*Config).Validate(0xc0000da200)
    /opt/app/config/config.go:201 +0x8a
github.com/binance-chain/bsc-relayer/config.ParseConfigFromFile(0x7fffe05c4e10, 0x1b, 0xb)
    /opt/app/config/config.go:225 +0xe2
main.main()
    /opt/app/main.go:90 +0x131
yutianwu commented 3 years ago

you need to add unconfirmed_tx_threshold in your config.toml

moesaleh commented 3 years ago

@yutianwu What's the recommended threshold?

yutianwu commented 3 years ago

depends on you, like hundreds?

moesaleh commented 3 years ago

What's the consequences of putting 1 or 100?

yutianwu commented 3 years ago

just put it to 500

moesaleh commented 3 years ago

Thanks a lot @yutianwu

tdiesler commented 3 years ago

Again, this should be properly documented before closing this issue. As it stands now, it is not clear from the main README how to configure the Relayer properly.

Perhaps, you could work through a fresh setup and verify that the docs are correct/complete.