search

bnb-chain / bsc

A BNB Smart Chain client based on the go-ethereum fork
GNU Lesser General Public License v3.0
2.63k stars 1.52k forks source link

2 prysm dependencies in go.mod with different version. #2553

Closed zzzckck closed 1 day ago

zzzckck commented 1 week ago

Description

we may have another issue: 2 prysm dependencies in go.mod with different version.

➜  bsc git:(03f9326f1) cat go.mod|grep "prysm"
    github.com/prysmaticlabs/prysm/v5 v5.0.3
    github.com/prysmaticlabs/prysm v0.0.0-20220124113610-e26cde5e091b // indirect
0.20210702154020-550e1cd83ec1

v5.0.3: was for BSC BLS related v0.0.0-20220124113610-e26cde5e091b: was imported indirectly for GreenField precompile contract.

➜  bsc git:(03f9326f1) go mod why -m github.com/prysmaticlabs/prysm
# github.com/prysmaticlabs/prysm
github.com/ethereum/go-ethereum/core/vm/lightclient/v2
github.com/cometbft/cometbft/light
github.com/cometbft/cometbft/light/provider/http
github.com/cometbft/cometbft/rpc/client
github.com/cometbft/cometbft/rpc/core/types
github.com/cometbft/cometbft/votepool
github.com/prysmaticlabs/prysm/crypto/bls/blst
➜  bsc git:(03f9326f1) go mod why -m github.com/prysmaticlabs/prysm/v5
# github.com/prysmaticlabs/prysm/v5
github.com/ethereum/go-ethereum/cmd/geth
github.com/prysmaticlabs/prysm/v5/crypto/bls

it would be better if we can unified the dependency of prysm.

KeefeL commented 2 days ago

Fixed in https://github.com/bnb-chain/bsc/pull/2556