search

bnb-chain / bsc

A BNB Smart Chain client based on the go-ethereum fork
GNU Lesser General Public License v3.0
2.73k stars 1.56k forks source link

Question regarding pbss and pruning #2555

Closed zhk101 closed 4 months ago

zhk101 commented 4 months ago

A few weeks back I read some issues related to pruning not working anymore or causing issues with the latest version of geth. I've recently saw some commit around fixing pruning (eg: #2481). Also read (https://www.bnbchain.org/en/blog/optimizing-blockchain-storage-bscs-path-based-storage-system) that PBSS, introduced in BSC's V1.3.1-beta release, addresses these concerns by introducing an online state prune feature

My node is using a path-based (pbss) snapshot from bnb48. I've removed a while ago the prunestate parameter to my node startup params. Can it be added back now? Is it still needed? Also, if a node has been running for long without that flag, can it be added later on and would it prune its backlog?

zzzckck commented 4 months ago

I've removed a while ago the prunestate parameter to my node startup params.

==== what is the params? do you mean "--pruneancient"?

zhk101 commented 4 months ago

what is the params? do you mean "--pruneancient"?

yes, that one

zzzckck commented 4 months ago

what is the params? do you mean "--pruneancient"?

yes, that one

There is some potential issue regarding to this flag: "--pruneancient", we are working on it, better not use this flag right now. But for nodes that are already running with flag, it is fine, no need to switch it off.