bnb-chain / go-sdk

Apache License 2.0
205 stars 97 forks source link

Mismatch of docs/code of getting account balances #98

Closed cbarraford closed 4 years ago

cbarraford commented 5 years ago

I noticed the documentation on how to query for account balances, and how the code does it in this repo is different.

In the code you're using /account/<addr>... https://github.com/binance-chain/go-sdk/blob/master/client/rpc/dex_client.go#L144

But in the docs you're using /store/acc/key... https://docs.binance.org/api-reference/node-rpc.html#619-abciquery

Which one is correct?

unclezoro commented 5 years ago

the code is right. I will ask the community correct the doc

chainwhisper commented 5 years ago

I think both are correct. The way dexclient using is more accurate when the account states change very quickly.